[jira] [Commented] (LENS-9) Checkstyle/Findbugs violations in code

["Rajat Khandelwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LENS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227360#comment-14227360 ] 

Rajat Khandelwal commented on LENS-9:
-------------------------------------

What is the accepted norm for javadoc formatting? Because my IDE is converting 
{code}
/** The num cols. */
{code}
to
{code}
 /**
   * The num cols.	
   */
{code}

And 
{code}
  /**
     * Instantiates a new lens row writer.
     *
     * @param out
     *          the out
     * @param encoding
     *          the encoding
     * @param tmpPath
     *          the tmp path
     * @param extn
     *          the extn
     */
{code}
to 
{code}
 /**
     * Instantiates a new lens row writer.
     *
     * @param out      the out
     * @param encoding the encoding
     * @param tmpPath  the tmp path
     * @param extn     the extn
     */
{code}



> Checkstyle/Findbugs violations in code
> --------------------------------------
>
>                 Key: LENS-9
>                 URL: https://issues.apache.org/jira/browse/LENS-9
>             Project: Apache Lens
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Srikanth Sundarrajan
>            Priority: Minor
>             Fix For: 2.0
>
>
> There are a few checkstyle violations in code. It would help to eliminate at least the ones that are potentially critical. It would in general makes things better if all of them are addressed and we enable failOnValidation. Also it looks like findbugs isn't enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)