You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/04 00:42:24 UTC
[GitHub] [beam] robertwb opened a new pull request, #23978: Add basic counter support to the typescript SDK.
robertwb opened a new pull request, #23978:
URL: https://github.com/apache/beam/pull/23978
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
robertwb merged PR #23978:
URL: https://github.com/apache/beam/pull/23978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #23978:
URL: https://github.com/apache/beam/pull/23978#discussion_r1014238089
##########
sdks/typescript/src/apache_beam/worker/metrics.ts:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as protobufjs from "protobufjs";
+
+import { MonitoringInfo } from "../proto/metrics";
+import { Coder, Context } from "../coders/coders";
+import { IterableCoder } from "../coders/required_coders";
+import { VarIntCoder } from "../coders/standard_coders";
+
+export interface MetricSpec {
+ metricType: string;
+ name: string;
+}
+
+const metricTypes = new Map<
+ string,
+ (spec: MetricSpec) => MetricCell<unknown>
+>();
+
+/**
+ * A MetricCell holds the concrete value of a metric at runtime.
+ *
+ * Different types of metrics will have different types of MetricCells,
+ * with the relationship being stored in the metricTypes map.
+ */
+interface MetricCell<T> {
+ // This is the publicly available function at execution time.
+ update: (value: T) => void;
+
+ // Rather than clear and re-create counters every time, we reset them
+ // between bundles.
+ reset: () => void;
+
+ // These are used to pass counters back from the worker.
+ toEmptyMonitoringInfo: () => MonitoringInfo;
+ payload: () => Uint8Array;
+
+ // These are used for reading counters.
+ loadFromPayload: (paylaod: Uint8Array) => void;
+ merge(other: MetricCell<T>);
+ extract(): any;
+}
+
+class Counter implements MetricCell<number> {
+ private value = 0;
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ this.value += value;
+ }
+
+ reset(): void {
+ this.value = 0;
+ }
+
+ toEmptyMonitoringInfo(): MonitoringInfo {
+ return MonitoringInfo.create({
+ urn: "beam:metric:user:sum_int64:v1",
+ type: "beam:metrics:sum_int64:v1",
+ });
+ }
+
+ payload(): Uint8Array {
+ return encode(this.value, new VarIntCoder());
+ }
+
+ loadFromPayload(payload: Uint8Array) {
+ this.value = decode(payload, new VarIntCoder());
+ }
+
+ merge(other) {
+ this.value += other.value;
+ }
+
+ extract() {
+ return this.value;
+ }
+}
+
+metricTypes.set("beam:metric:user:sum_int64:v1", (spec) => new Counter(spec));
+
+class Distribution implements MetricCell<number> {
+ private count = 0;
+ private sum = 0;
+ private min = 0;
+ private max = 0;
+
+ private coder = new IterableCoder(new VarIntCoder());
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ if (this.count == 0) {
+ this.count = 1;
+ this.sum = this.min = this.max = value;
+ } else {
+ this.count += 1;
+ this.sum += value;
+ this.min = Math.min(value, this.min);
+ this.max = Math.max(value, this.max);
+ }
+ }
+
+ reset(): void {
+ this.count = 0;
Review Comment:
Ah, good catch. Nothing should be done with a metric that hasn't been updated at least once. I've added some logic to only actually report those counters that are actually updated. In addition, as a precaution, I've also updated the distribution merge function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23978:
URL: https://github.com/apache/beam/pull/23978#issuecomment-1302828207
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23978:
URL: https://github.com/apache/beam/pull/23978#discussion_r1014288871
##########
sdks/typescript/src/apache_beam/worker/metrics.ts:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as protobufjs from "protobufjs";
+
+import { MonitoringInfo } from "../proto/metrics";
+import { Coder, Context } from "../coders/coders";
+import { IterableCoder } from "../coders/required_coders";
+import { VarIntCoder } from "../coders/standard_coders";
+
+export interface MetricSpec {
+ metricType: string;
+ name: string;
+}
+
+const metricTypes = new Map<
+ string,
+ (spec: MetricSpec) => MetricCell<unknown>
+>();
+
+/**
+ * A MetricCell holds the concrete value of a metric at runtime.
+ *
+ * Different types of metrics will have different types of MetricCells,
+ * with the relationship being stored in the metricTypes map.
+ */
+interface MetricCell<T> {
+ // This is the publicly available function at execution time.
+ update: (value: T) => void;
+
+ // Rather than clear and re-create counters every time, we reset them
+ // between bundles.
+ reset: () => void;
+
+ // These are used to pass counters back from the worker.
+ toEmptyMonitoringInfo: () => MonitoringInfo;
+ payload: () => Uint8Array;
+
+ // These are used for reading counters.
+ loadFromPayload: (paylaod: Uint8Array) => void;
+ merge(other: MetricCell<T>);
+ extract(): any;
+}
+
+class Counter implements MetricCell<number> {
+ private value = 0;
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ this.value += value;
+ }
+
+ reset(): void {
+ this.value = 0;
+ }
+
+ toEmptyMonitoringInfo(): MonitoringInfo {
+ return MonitoringInfo.create({
+ urn: "beam:metric:user:sum_int64:v1",
+ type: "beam:metrics:sum_int64:v1",
+ });
+ }
+
+ payload(): Uint8Array {
+ return encode(this.value, new VarIntCoder());
+ }
+
+ loadFromPayload(payload: Uint8Array) {
+ this.value = decode(payload, new VarIntCoder());
+ }
+
+ merge(other) {
+ this.value += other.value;
+ }
+
+ extract() {
+ return this.value;
+ }
+}
+
+metricTypes.set("beam:metric:user:sum_int64:v1", (spec) => new Counter(spec));
+
+class Distribution implements MetricCell<number> {
+ private count = 0;
+ private sum = 0;
+ private min = 0;
+ private max = 0;
+
+ private coder = new IterableCoder(new VarIntCoder());
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ if (this.count == 0) {
+ this.count = 1;
+ this.sum = this.min = this.max = value;
+ } else {
+ this.count += 1;
+ this.sum += value;
+ this.min = Math.min(value, this.min);
+ this.max = Math.max(value, this.max);
+ }
+ }
+
+ reset(): void {
+ this.count = 0;
Review Comment:
Sounds good, this LGTM (other than the new merge conflicts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23978:
URL: https://github.com/apache/beam/pull/23978#issuecomment-1302827789
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23978: Add basic counter support to the typescript SDK.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23978:
URL: https://github.com/apache/beam/pull/23978#discussion_r1013984800
##########
sdks/typescript/src/apache_beam/worker/metrics.ts:
##########
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as protobufjs from "protobufjs";
+
+import { MonitoringInfo } from "../proto/metrics";
+import { Coder, Context } from "../coders/coders";
+import { IterableCoder } from "../coders/required_coders";
+import { VarIntCoder } from "../coders/standard_coders";
+
+export interface MetricSpec {
+ metricType: string;
+ name: string;
+}
+
+const metricTypes = new Map<
+ string,
+ (spec: MetricSpec) => MetricCell<unknown>
+>();
+
+/**
+ * A MetricCell holds the concrete value of a metric at runtime.
+ *
+ * Different types of metrics will have different types of MetricCells,
+ * with the relationship being stored in the metricTypes map.
+ */
+interface MetricCell<T> {
+ // This is the publicly available function at execution time.
+ update: (value: T) => void;
+
+ // Rather than clear and re-create counters every time, we reset them
+ // between bundles.
+ reset: () => void;
+
+ // These are used to pass counters back from the worker.
+ toEmptyMonitoringInfo: () => MonitoringInfo;
+ payload: () => Uint8Array;
+
+ // These are used for reading counters.
+ loadFromPayload: (paylaod: Uint8Array) => void;
+ merge(other: MetricCell<T>);
+ extract(): any;
+}
+
+class Counter implements MetricCell<number> {
+ private value = 0;
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ this.value += value;
+ }
+
+ reset(): void {
+ this.value = 0;
+ }
+
+ toEmptyMonitoringInfo(): MonitoringInfo {
+ return MonitoringInfo.create({
+ urn: "beam:metric:user:sum_int64:v1",
+ type: "beam:metrics:sum_int64:v1",
+ });
+ }
+
+ payload(): Uint8Array {
+ return encode(this.value, new VarIntCoder());
+ }
+
+ loadFromPayload(payload: Uint8Array) {
+ this.value = decode(payload, new VarIntCoder());
+ }
+
+ merge(other) {
+ this.value += other.value;
+ }
+
+ extract() {
+ return this.value;
+ }
+}
+
+metricTypes.set("beam:metric:user:sum_int64:v1", (spec) => new Counter(spec));
+
+class Distribution implements MetricCell<number> {
+ private count = 0;
+ private sum = 0;
+ private min = 0;
+ private max = 0;
+
+ private coder = new IterableCoder(new VarIntCoder());
+
+ constructor(spec: MetricSpec) {}
+
+ update(value: number) {
+ if (this.count == 0) {
+ this.count = 1;
+ this.sum = this.min = this.max = value;
+ } else {
+ this.count += 1;
+ this.sum += value;
+ this.min = Math.min(value, this.min);
+ this.max = Math.max(value, this.max);
+ }
+ }
+
+ reset(): void {
+ this.count = 0;
Review Comment:
Should we be resetting the rest of the metrics here? I know functionally that they'll be reset on the first update, but this might lead to weird/unexpected behavior if any operation is done with an unupdated metric.
I guess maybe a better question is: is it ever valid to do anything with a metric that hasn't been updated at least once? If so, things like merge won't ever really work and we'd be better off initializing min to MAX_INT, max to MIN_INT, and fully resetting them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org