You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/26 22:56:14 UTC

[GitHub] [superset] eschutho commented on pull request #12754: chore: add breaking change to title regex

eschutho commented on pull request #12754:
URL: https://github.com/apache/superset/pull/12754#issuecomment-767881855


   > The prefixes are task types. "Breaking change" sounds more like a flag or label.
   > 
   > [Conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#specification) specifies breaking changes should add `!` to task type, or include `BREAKING CHANGE:` in the footer. E.g.
   > 
   > ```
   > refactor!: drop support for Python 3.6
   > ```
   > 
   > or
   > 
   > ```
   > refactor!: drop support for Python 3.6
   > 
   > BREAKING CHANGE: as discussed in #xxxx, Python 3.6 is no longer supported.
   > ```
   > 
   > I think it'd be worthwhile following the best practices from the community.
   
   Thanks, this is a good resource @ktmud. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org