You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/09/22 09:48:19 UTC
[PR] Added derive for arbitrary [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2193:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193
Adds `Arbitrary` derives to all AST structs and enums for property-based testing and fuzzing.
## Changes
- Added `arbitrary` as optional dependency with feature gating
- Derived `Arbitrary` on all public AST types in ast
- Added `Arbitrary` to core types (`Token`, `Span`, `Location`, etc.)
- Excluded display helpers and iterators
**Note**: `BigDecimal` (used in `Value::Number`) lacks `Arbitrary` support. PR submitted: https://github.com/akubera/bigdecimal-rs/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Added derive for arbitrary [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2193:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193#issuecomment-5774427229
Will need rebasing, but finally https://github.com/akubera/bigdecimal-rs/pull/163 has been merged and hopefully a new version of bigdecimal will be published soonish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Added derive for arbitrary [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2193:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193#issuecomment-4236022106
This type of GitHub Actions is not positive IMHO. This PR is blocked by another PR uphill, and closing it does not make the problem go away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Added derive for arbitrary [datafusion-sqlparser-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2193:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193#issuecomment-4190018413
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Added derive for arbitrary [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2193:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193#issuecomment-5956239798
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2193?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.13%. Comparing base ([`c70b5b1`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/c70b5b142374d4264fdb6401ee4bbac58013af11?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d33f2e`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/8d33f2e0bdd0d6d612a3b4e0b720d804d12c6cea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2193?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/ast/value.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2193?src=pr&el=tree&filepath=src%2Fast%2Fvalue.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC92YWx1ZS5ycw==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 81.14% 81.13% -0.02%
==========================================
Files 42 42
Lines 33739 33744 +5
Branches 33739 33744 +5
==========================================
Hits 27379 27379
- Misses 2797 2802 +5
Partials 3563 3563
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2193?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Added derive for arbitrary [datafusion-sqlparser-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2193: Added derive for arbitrary
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org