You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/27 08:53:19 UTC
[GitHub] [dolphinscheduler] zhongjiajie opened a new issue #8222: [Feature][python] Add add example into dist package
zhongjiajie opened a new issue #8222:
URL: https://github.com/apache/dolphinscheduler/issues/8222
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
For now, our examples are out of scope from the source package https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-python/pydolphinscheduler/examples. It makes our examples only work at source code. we should add them to dist package to run it after we install from pypi
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #8222: [Feature][python] Add add example into dist package
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #8222:
URL: https://github.com/apache/dolphinscheduler/issues/8222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8222: [Feature][python] Add add example into dist package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8222:
URL: https://github.com/apache/dolphinscheduler/issues/8222#issuecomment-1022988443
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #8222: [Feature][python] Add add example into dist package
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #8222:
URL: https://github.com/apache/dolphinscheduler/issues/8222#issuecomment-1034928137
I simply added a `__init__.py` file into folder `examples` and moved `examples` into the folder `src/pydolphinscheduler/` folder. It works. Correct me if I'm wrong.
Here's the pr link: https://github.com/apache/dolphinscheduler/pull/8340
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8222: [Feature][python] Add add example into dist package
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8222:
URL: https://github.com/apache/dolphinscheduler/issues/8222#issuecomment-1035729364
> I simply added a `__init__.py` file into folder `examples` and moved `examples` into the folder `src/pydolphinscheduler/` folder. It works. Correct me if I'm wrong.
>
> Here's the pr link: #8340
>
> Thanks.
Sure, it could be done by this, please make sure we have some example test in `tests/example/` and `tests/test_docs.py` which run some test about example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org