You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/12/07 03:24:37 UTC
Review Request 64402: HIVE-18240 support getClientInfo/setClientInfo
in JDBC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64402/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
see jira
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 87595ee415
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7f21bd3842
service-rpc/if/TCLIService.thrift a1f293bdc2
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7fbcd13b63
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java fc9e6b2a91
Diff: https://reviews.apache.org/r/64402/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 64402: HIVE-18240 support
getClientInfo/setClientInfo in JDBC
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64402/#review193193
-----------------------------------------------------------
Ship it!
Ship It!
- Vaibhav Gumashta
On Dec. 7, 2017, 3:24 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64402/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 3:24 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 87595ee415
> jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7f21bd3842
> service-rpc/if/TCLIService.thrift a1f293bdc2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7fbcd13b63
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java fc9e6b2a91
>
>
> Diff: https://reviews.apache.org/r/64402/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 64402: HIVE-18240 support
getClientInfo/setClientInfo in JDBC
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64402/#review193093
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
Lines 305 (patched)
<https://reviews.apache.org/r/64402/#comment271586>
this should be removed
- Sergey Shelukhin
On Dec. 7, 2017, 3:24 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64402/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 3:24 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 87595ee415
> jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7f21bd3842
> service-rpc/if/TCLIService.thrift a1f293bdc2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7fbcd13b63
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java fc9e6b2a91
>
>
> Diff: https://reviews.apache.org/r/64402/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>