You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Sergey Vladimirov (JIRA)" <ji...@apache.org> on 2008/06/16 18:07:45 UTC

[jira] Created: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Extract initTransport() method from AxisServlet::init( ServletConfig )
----------------------------------------------------------------------

                 Key: AXIS2-3863
                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
             Project: Axis 2.0 (Axis2)
          Issue Type: Improvement
          Components: transports
    Affects Versions: nightly
            Reporter: Sergey Vladimirov
            Priority: Trivial
             Fix For: nightly
         Attachments: patch.txt

Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Vladimirov updated AXIS2-3863:
-------------------------------------

    Priority: Minor  (was: Trivial)

> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606288#action_12606288 ] 

Andreas Veithen commented on AXIS2-3863:
----------------------------------------

Splitting the code in AxisServlet#init into several initXxx methods (as with the existing initParams method) indeed makes sense. When done in the right way this would allow subclasses to change the initialization behavior in a proper way by either overriding individual initXxx methods or overriding init and calling existing initXxx methods.

> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Vladimirov updated AXIS2-3863:
-------------------------------------

    Attachment: patch.txt

> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Trivial
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605453#action_12605453 ] 

Andreas Veithen commented on AXIS2-3863:
----------------------------------------

This should not be required if the shutdown hook is removed in ListenerManager#stop (see AXIS2-3861 and AXIS2-3862).

> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606274#action_12606274 ] 

Sergey Vladimirov commented on AXIS2-3863:
------------------------------------------

it won't be required for my project, but what if someone will need to extends Listenermanager for another reason?

> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Issue Comment Edited: (AXIS2-3863) Extract initTransport() method from AxisServlet::init( ServletConfig )

Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606274#action_12606274 ] 

bsp edited comment on AXIS2-3863 at 6/19/08 12:33 AM:
--------------------------------------------------------------------

it won't be required for my project, but what if someone will need to extends AxisServlet for another reason?

      was (Author: bsp):
    it won't be required for my project, but what if someone will need to extends Listenermanager for another reason?
  
> Extract initTransport() method from AxisServlet::init( ServletConfig )
> ----------------------------------------------------------------------
>
>                 Key: AXIS2-3863
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3863
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: transports
>    Affects Versions: nightly
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>             Fix For: nightly
>
>         Attachments: patch.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Extracting initTransport() method allows more accurate subclassing

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org