You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/01 21:43:10 UTC
[GitHub] [airflow] sjvanrossum opened a new pull request #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in Str…
sjvanrossum opened a new pull request #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in Str…
URL: https://github.com/apache/airflow/pull/7329
…eamLogWriter
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in Str…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in Str…
URL: https://github.com/apache/airflow/pull/7329#issuecomment-581072311
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7329:
[AIRFLOW-3349] Use None instead of False as value for encoding in
StreamLogWriter
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in StreamLogWriter
URL: https://github.com/apache/airflow/pull/7329#issuecomment-581124723
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7329:
[AIRFLOW-3349] Use None instead of False as value for encoding in
StreamLogWriter
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in StreamLogWriter
URL: https://github.com/apache/airflow/pull/7329#issuecomment-581075478
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=h1) Report
> Merging [#7329](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/39375c01ced008a715bb2a540df31fe2cf908bbb?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7329/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7329 +/- ##
==========================================
+ Coverage 85.59% 85.83% +0.23%
==========================================
Files 863 863
Lines 40520 40520
==========================================
+ Hits 34685 34779 +94
+ Misses 5835 5741 -94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/log/logging\_mixin.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvbG9nZ2luZ19taXhpbi5weQ==) | `95.38% <100%> (ø)` | :arrow_up: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.34% <0%> (+0.14%)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `77.4% <0%> (+0.96%)` | :arrow_up: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `77.55% <0%> (+1.53%)` | :arrow_up: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `100% <0%> (+45%)` | :arrow_up: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `76.08% <0%> (+45.65%)` | :arrow_up: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=footer). Last update [39375c0...7c34ff1](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #7329: [AIRFLOW-3349]
Use None instead of False as value for encoding in StreamLogWriter
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in StreamLogWriter
URL: https://github.com/apache/airflow/pull/7329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7329: [AIRFLOW-3349] Use
None instead of False as value for encoding in StreamLogWriter
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7329: [AIRFLOW-3349] Use None instead of False as value for encoding in StreamLogWriter
URL: https://github.com/apache/airflow/pull/7329#issuecomment-581075478
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=h1) Report
> Merging [#7329](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/39375c01ced008a715bb2a540df31fe2cf908bbb?src=pr&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7329/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7329 +/- ##
==========================================
+ Coverage 85.59% 85.83% +0.23%
==========================================
Files 863 863
Lines 40520 40520
==========================================
+ Hits 34685 34779 +94
+ Misses 5835 5741 -94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/log/logging\_mixin.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvbG9nZ2luZ19taXhpbi5weQ==) | `95.38% <100%> (ø)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.66% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7329/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=footer). Last update [39375c0...7c34ff1](https://codecov.io/gh/apache/airflow/pull/7329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services