You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by amansinha100 <gi...@git.apache.org> on 2016/03/14 00:27:18 UTC

[GitHub] drill pull request: DRILL-4503: Write nulls as varchar when all_te...

GitHub user amansinha100 opened a pull request:

    https://github.com/apache/drill/pull/428

    DRILL-4503: Write nulls as varchar when all_text_mode is enabled.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amansinha100/incubator-drill DRILL-4503

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #428
    
----
commit 882dc2dc66383d41867f18626443b6e2e81c8ea3
Author: Aman Sinha <as...@maprtech.com>
Date:   2016-03-13T22:42:57Z

    DRILL-4503: Write nulls as varchar when all_text_mode is enabled.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4503: Write nulls as varchar when all_te...

Posted by amansinha100 <gi...@git.apache.org>.
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/428#discussion_r55952285
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java ---
    @@ -402,7 +402,8 @@ private void writeDataAllText(MapWriter map, FieldSelection selection, boolean m
             handleString(parser, map, fieldName);
             break;
           case VALUE_NULL:
    -        // do nothing as we don't have a type.
    --- End diff --
    
    Good point...these would fail to read due to the complex type field under all_text_mode.  Let me see if there's a common solution to both types of use cases (the ones in my unit tests and the ones here)..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4503: Write nulls as varchar when all_te...

Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/428#discussion_r55946493
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java ---
    @@ -402,7 +402,8 @@ private void writeDataAllText(MapWriter map, FieldSelection selection, boolean m
             handleString(parser, map, fieldName);
             break;
           case VALUE_NULL:
    -        // do nothing as we don't have a type.
    --- End diff --
    
    Won't this cause both of these files to fail to read?
    
    FILE1
    {a: 4, b:null}
    {a:6, b: [1,2,3]}
    
    FILE2
    {a:4, b:null}
    {a:6, b: {x:1, y:2}}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---