You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:59:56 UTC
[GitHub] [hudi] danny0405 commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
danny0405 commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r686592278
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
+ .intType()
+ .defaultValue(20000)
+ .withDescription("Maximum amount of time (in ms), to wait for consistency checking.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECKS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_checks")
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
Review comment:
Can we use shorter name for flink options: consistency.check.enabled
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org