[jira] Commented: (HADOOP-4599) BlocksMap and BlockInfo should be package private.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645717#action_12645717 ] 

Hadoop QA commented on HADOOP-4599:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393417/PkgRpivateBlocksMap.patch
  against trunk revision 712033.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/console

This message is automatically generated.

> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
>                 Key: HADOOP-4599
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4599
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.20.0
>
>         Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.