[jira] [Comment Edited] (PHOENIX-53) Replace CSV loader with Apache Commons CSV loader

["James Violette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920111#comment-13920111 ] 

James Violette edited comment on PHOENIX-53 at 3/4/14 10:18 PM:
----------------------------------------------------------------

 It looks like we need to add toString() to ColumnInfo to support the print statement. I had that in a local copy, but did not supply it as part of the patch.

public class ColumnInfo {
	public String toString() {
		return columnName+" "+PDataType.fromTypeId(sqlType).getSqlTypeName();
	}
}


was (Author: jviolettedsiq):
 It looks like we need to add toString() to ColumnInfo to support the print statement. I had that in a local copy, but did not supply it as part of the patch.

public class ColumnInfo {
	public String toString() {
		return columnName+" "+PDataType.fromSqlType(sqlType).getSqlTypeName();
	}
}

> Replace CSV loader with Apache Commons CSV loader
> -------------------------------------------------
>
>                 Key: PHOENIX-53
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-53
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 2.2.3, 3.0.0
>            Reporter: James Violette
>              Labels: patch
>             Fix For: 3.0.0
>
>         Attachments: commons-csv-1.0-SNAPSHOT-sources.jar, commons-csv-1.0-SNAPSHOT.jar, csvloaderoverrides.diff, csvloadersource.diff, incubator-phoenix-commons-csv-rev2-3.0.0.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an empty line.  This occurs if all lines end with the new line character and the reader returns an empty line at the end. Other issues, such as encapsulated meta characters also occur.
> The fix is to replace the opencsv library with the current apache commons-csv library.



--
This message was sent by Atlassian JIRA
(v6.2#6252)