[PR] Harden release + verify scripts for SVN upload and local artifact dirs [hamilton]

["skrawcz (via GitHub)" <gi...@apache.org>]

skrawcz opened a new pull request, #1641:
URL: https://github.com/apache/hamilton/pull/1641

   These bugs surfaced while cutting the apache-hamilton-{sdk,ui,lsp,contrib} RC1 release.
   
   ## `scripts/apache_release_helper.py`
   
   **Absolute artifact paths.** `create_release_artifacts` chdir's into the package `working_dir` to build, but `svn_upload` runs from the repo root. The previously-returned **relative** paths then failed to resolve, producing:
   
   ```
   svn: E000002: Can't stat '/Users/.../hamilton/dist/apache-hamilton-contrib-0.0.9-incubating-src.tar.gz': No such file or directory
   ```
   
   Now returns absolute paths so the import works regardless of CWD.
   
   **Resumable SVN upload.** `svn_upload` unconditionally ran `svn mkdir` with `check=True`. If a prior run partially uploaded (dir created, some files imported) a re-run aborted on `svn mkdir` ('directory already exists'). Now a pre-existing RC directory is tolerated so the re-run resumes importing the remaining files. (This is exactly what happened with contrib RC1, which uploaded only 2 of 6 files.)
   
   ## `scripts/verify-sub-packages/*.sh` (all 4)
   
   The functional-verification step does `cd /tmp` (so the local hamilton checkout doesn't shadow venv-installed packages via `''` on `sys.path`), but then referenced `$ARTIFACTS_DIR` relatively — breaking when a relative local artifacts dir was passed (e.g. `verify_sdk.sh 0.9.0 1 ui/sdk/dist`):
   
   ```
   error: Distribution not found at: file:///private/tmp/ui/sdk/dist/apache_hamilton_sdk-...whl
   ```
   
   Now `ARTIFACTS_DIR` is resolved to an absolute path right after acquisition.
   
   ## Verification
   All four verify scripts were re-run end-to-end against the live SVN RC1 artifacts after these fixes and passed (GPG, SHA512, RAT, build-from-source, functional).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Harden release + verify scripts for SVN upload and local artifact dirs [hamilton]

["skrawcz (via GitHub)" <gi...@apache.org>]

skrawcz merged PR #1641:
URL: https://github.com/apache/hamilton/pull/1641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org