[GitHub] [flink] yangjunhan commented on a diff in pull request #19789: [FLINK-27734][web] Fix checkpoint interval in WebUI

[GitBox <gi...@apache.org>]

yangjunhan commented on code in PR #19789:
URL: https://github.com/apache/flink/pull/19789#discussion_r893012727


##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -500,10 +500,10 @@
           </tr>
           <tr>
             <td>Interval</td>
-            <td *ngIf="checkPointConfig['interval'] === '0x7fffffffffffffff'">
+            <td *ngIf="checkPointConfig['interval'] == '0x7fffffffffffffff'">
               Periodic checkpoints disabled
             </td>
-            <td *ngIf="checkPointConfig['interval'] !== '0x7fffffffffffffff'">
+            <td *ngIf="checkPointConfig['interval'] != '0x7fffffffffffffff'">

Review Comment:
   Same as above.



##########
flink-runtime-web/web-dashboard/.eslintrc.js:
##########
@@ -126,7 +126,9 @@ module.exports = {
     {
       files: ['*.html'],
       extends: ['plugin:@angular-eslint/template/recommended'],
-      rules: {}
+      rules: {
+        '@angular-eslint/template/eqeqeq': 'warn'

Review Comment:
   Don't do this. You shouldn't allow Abstract Equality Comparison, and always prefer Strict Equality Comparison for being type-safe.



##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -500,10 +500,10 @@
           </tr>
           <tr>
             <td>Interval</td>
-            <td *ngIf="checkPointConfig['interval'] === '0x7fffffffffffffff'">
+            <td *ngIf="checkPointConfig['interval'] == '0x7fffffffffffffff'">

Review Comment:
   ```suggestion
               <td *ngIf="checkPointConfig['interval'] === disabledInterval">
   ```
   
   You can utilize the Angular property binding to fix this issue. 
   
   Define `disabledInterval = 0x7fffffffffffffff` in the `JobCheckpointsComponent` class. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org