You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/04/03 12:29:16 UTC
Review Request 58147: AMBARI-19149. Code cleanup: StringBuffer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58147/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149
Repository: ambari
Description
-------
Replace `StringBuffer` with `StringBuilder`.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/HostsRemovedEvent.java 41458605ef21e00e65a5adbe2c4e5dace7ec54e3
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java 0521aa1da4e85ec2688417951c01875012e41463
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java 9f9ded61b383b4ee5d4e7740f9dadd15921d89fe
Diff: https://reviews.apache.org/r/58147/diff/1/
Testing
-------
```
$ mvn -am -pl ambari-server clean test-compile
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 58147: AMBARI-19149. Code cleanup: StringBuffer
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58147/#review170866
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On April 3, 2017, 12:29 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58147/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 12:29 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace `StringBuffer` with `StringBuilder`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/HostsRemovedEvent.java 41458605ef21e00e65a5adbe2c4e5dace7ec54e3
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java 0521aa1da4e85ec2688417951c01875012e41463
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java 9f9ded61b383b4ee5d4e7740f9dadd15921d89fe
>
>
> Diff: https://reviews.apache.org/r/58147/diff/1/
>
>
> Testing
> -------
>
> ```
> $ mvn -am -pl ambari-server clean test-compile
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>