You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/07 00:12:58 UTC

[GitHub] [spark] maropu commented on a change in pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

maropu commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r421164055



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##########
@@ -48,7 +48,7 @@ private[sql] class DB2ConnectionProvider(driver: Driver, options: JDBCOptions)
     result
   }
 
-  override def setAuthenticationConfigIfNeeded(): Unit = {
+  override def setAuthenticationConfigIfNeeded(): Unit = SecurityConfigurationLock.synchronized {

Review comment:
       Thanks for the detailed info, @gaborgsomogyi . btw, is there any reference (documents, specification, ...) to the behaviour you described above?
   ```
   Worth to mention all the originally existing configuration is still reachable because if the searched application name is not matching with the newly added entry then the entry delegates the call to the parent.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org