[GitHub] storm pull request #2026: Eventhub3

[rban1 <gi...@git.apache.org>]

Github user rban1 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2026#discussion_r109327884
  
    --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/PartitionManager.java ---
    @@ -41,29 +41,29 @@ public PartitionManager(
     
         super(spoutConfig, partitionId, stateStore, receiver);
         
    -    this.pending = new LinkedHashMap<String, EventData>();
    -    this.toResend = new TreeSet<EventData>();
    +    this.pending = new LinkedHashMap<String, EventDataWrap>();
    +    this.toResend = new TreeSet<EventDataWrap>();
    --- End diff --
    
    it is indeed ordered by sequence number. The compareto definition in eventdatawrap class is as follows:
    @Override
      public int compareTo(EventDataWrap ed) {
        return messageId.getSequenceNumber().
            compareTo(ed.getMessageId().getSequenceNumber());
      }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---