You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2011/10/18 17:43:10 UTC

[jira] [Commented] (THRIFT-1393) TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message

    [ https://issues.apache.org/jira/browse/THRIFT-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129806#comment-13129806 ] 

Hudson commented on THRIFT-1393:
--------------------------------

Integrated in Thrift #299 (See [https://builds.apache.org/job/Thrift/299/])
    Thrift-1393: TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message
Client : php
Patch: Nick Jones

The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.

                
> TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message
> --------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1393
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1393
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.8
>            Reporter: Nick Jones
>            Assignee: Nick Jones
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: exception.patch
>
>
> This is a very minor issue, but should be addressed nonetheless.
> The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.
> Example:
> "THttpClient: Could not read 184549154 bytes from xxx.yyy.com:80//randomService"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira