You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/02 18:24:46 UTC

[GitHub] [geode] DonalEvans opened a new pull request #6674: GEODE-9187: Implement Radish ZREVRANK command

DonalEvans opened a new pull request #6674:
URL: https://github.com/apache/geode/pull/6674


    - Add ZREVRANK to supported commands
    - Arrange RedisSortedSet commands alphabetically in classes
    - Remove redundant zrank implementation in NullRedisSet
    - Add tests for ZREVRANK command
   
   Authored-by: Donal Evans <do...@vmware.com>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] DonalEvans commented on pull request #6674: GEODE-9187: Implement Radish ZREVRANK command

Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #6674:
URL: https://github.com/apache/geode/pull/6674#issuecomment-875749643


   Force pushed to rebase on develop, but also included a change that was not in the initial commit, changing the return type of internal zrank and zrevrank methods to be `long` rather than `int`, as per [the Redis documentation](https://redis.io/topics/protocol#integer-reply) regarding Integer returns: "the returned integer is guaranteed to be in the range of a signed 64 bit integer"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] DonalEvans merged pull request #6674: GEODE-9187: Implement Radish ZREVRANK command

Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #6674:
URL: https://github.com/apache/geode/pull/6674


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org