[jira] [Closed] (ARCHETYPE-691) Refactor FileCharsetDetector

["Slawomir Jaranowski (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARCHETYPE-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Slawomir Jaranowski closed ARCHETYPE-691.
-----------------------------------------
    Fix Version/s: next-release
         Assignee: Slawomir Jaranowski
       Resolution: Fixed

> Refactor FileCharsetDetector
> ----------------------------
>
>                 Key: ARCHETYPE-691
>                 URL: https://issues.apache.org/jira/browse/ARCHETYPE-691
>             Project: Maven Archetype
>          Issue Type: Improvement
>            Reporter: Elliotte Rusty Harold
>            Assignee: Slawomir Jaranowski
>            Priority: Minor
>              Labels: good-first-issue, up-for-grabs
>             Fix For: next-release
>
>
> This class is weird. It does all the work in the constructor and then uses getter methods. It should probably be a single public static method instead.
> Or better yet remove the public util class entirely and move the logic into the one place it's used as charset detection is not a fundamental feature of archetype creation. Keep the API focused. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)