[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5568: [QueryContext] Refactor PlanMaker to use QueryContext

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5568:
URL: https://github.com/apache/incubator-pinot/pull/5568#discussion_r441870453



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/PlanMaker.java
##########
@@ -20,36 +20,27 @@
 
 import java.util.List;
 import java.util.concurrent.ExecutorService;
-import org.apache.pinot.common.request.BrokerRequest;
-import org.apache.pinot.core.data.manager.SegmentDataManager;
 import org.apache.pinot.core.indexsegment.IndexSegment;
 import org.apache.pinot.core.plan.Plan;
 import org.apache.pinot.core.plan.PlanNode;
+import org.apache.pinot.core.query.request.context.QueryContext;
+import org.apache.pinot.spi.annotations.InterfaceAudience;
 
 
 /**
- * The <code>PlanMaker</code> provides interfaces to make segment level and instance level execution plan.
+ * The {@code PlanMaker} makes logical execution plan for the queries.
  */
+@InterfaceAudience.Private
 public interface PlanMaker {
 
   /**
-   * Make segment level {@link PlanNode} which contains execution plan on only one segment.
-   *
-   * @param indexSegment index segment.
-   * @param brokerRequest broker request.
-   * @return segment level plan node.
+   * Returns an instance level {@link Plan} which contains the logical execution plan for multiple segments.
    */
-  PlanNode makeInnerSegmentPlan(IndexSegment indexSegment, BrokerRequest brokerRequest);

Review comment:
       This seems like refactoring to me which is not really needed to move to QueryContext?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org