[GitHub] spark pull request #18628: [SPARK-18061][ThriftServer] Add spnego auth suppo...

[steveloughran <gi...@git.apache.org>]

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18628#discussion_r130598230
  
    --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala ---
    @@ -57,6 +59,19 @@ private[hive] class SparkSQLCLIService(hiveServer: HiveServer2, sqlContext: SQLC
             case e @ (_: IOException | _: LoginException) =>
               throw new ServiceException("Unable to login to kerberos with given principal/keytab", e)
           }
    +
    +      // Try creating spnego UGI if it is configured.
    +      val principal = hiveConf.getVar(ConfVars.HIVE_SERVER2_SPNEGO_PRINCIPAL)
    +      val keyTabFile = hiveConf.getVar(ConfVars.HIVE_SERVER2_SPNEGO_KEYTAB)
    +      if (principal.nonEmpty && keyTabFile.nonEmpty) {
    +        try {
    +          httpUGI = HiveAuthFactory.loginFromSpnegoKeytabAndReturnUGI(hiveConf)
    +          setSuperField(this, "httpUGI", httpUGI)
    +        } catch {
    +          case e: IOException =>
    +            throw new ServiceException("Unable to login to spnego with given principal/keytab", e)
    +        }
    --- End diff --
    
    I'd recommend including as much diagnostics in the exception string, including principal & keytab, and the value of e.toString in the message
    ```
    throw new ServiceException(s"Unable to login to spnego with principal `$principal and keytab `$keytab`: $e", e)
    ```
    
    The scenario to plan for is "nothing works and all you have to go on is that string from the raised exception". 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org