You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/16 07:46:38 UTC
[GitHub] [incubator-dolphinscheduler] linyanbin666 opened a new pull request #4474: [Feature-4463][UI]: Add an option to the UI page for saving the workflow definition: whether to go online?
linyanbin666 opened a new pull request #4474:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4474
## What is the purpose of the pull request
Implement UI #4463
## Brief change log
- Add variable 'releaseState', which indicates whether to go online or not. 0 means not to go online, 1 means online, online by default
- Add a checkbox option and show it when saving the workflow definition in detail page
- Add 'releaseState' param in 'updateDefinition' action method
## Verify this pull request
- Manually verified the change by testing locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #4474: [Feature-4463][UI]: Add an option to the UI page for saving the workflow definition: whether to go online?
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #4474:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4474#issuecomment-761581592
Thanks for your first contribution, looking forward to your deep participation.
please contact me (wechat: 510570367 or lidongdai@apache.org), when added, please tell me your github id, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4474: [Feature-4463][UI]: Add an option to the UI page for saving the workflow definition: whether to go online?
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4474:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4474#issuecomment-761524246
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=h1) Report
> Merging [#4474](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=desc) (2cb4dbb) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8c47dcb694e53c3a0054e7cdb66aa3969183b7f8?el=desc) (8c47dcb) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4474 +/- ##
============================================
- Coverage 43.34% 43.33% -0.01%
+ Complexity 3195 3194 -1
============================================
Files 471 471
Lines 21831 21831
Branches 2648 2648
============================================
- Hits 9462 9460 -2
- Misses 11465 11467 +2
Partials 904 904
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `60.97% <0.00%> (-4.88%)` | `7.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=footer). Last update [8c47dcb...2cb4dbb](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4474: [Feature-4463][UI]: Add an option to the UI page for saving the workflow definition: whether to go online?
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4474:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4474#issuecomment-761524568
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4474&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4474&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4474&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4474&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #4474: [Feature-4463][UI]: Add an option to the UI page for saving the workflow definition: whether to go online?
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #4474:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org