You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/01/02 06:42:58 UTC
[GitHub] [james-project] chibenwa opened a new pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
chibenwa opened a new pull request #286:
URL: https://github.com/apache/james-project/pull/286
We needlessly copy mime messages in a few occasions:
- After receiving an email via SMTP and enqueuing it
- When instantiating a Mail via JMAP
- When dequeuing a mail
In all these cases there is no need to proceed with the defensive copy
in MailImpl::setMail as we just instanciated it and won't keep a reference.
The COW approach did hide this pitfall.
With these changes, the 'always copy' code is on par performance wise with the 'COW' one, without its drawbacks.
Identified while benching https://github.com/apache/james-project/pull/285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-780238747
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #286:
URL: https://github.com/apache/james-project/pull/286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-780221455
On master:
On this branch:
Sorry for the delays, I had to reboot Linagora's James' bench CI, and it did not work out of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-783857047
I merged this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-778995406
Still getting the
```
05:02:42.728 [ERROR] o.a.j.m.i.c.CamelProcessor - Exception calling Sieve: Mail message to be spooled cannot be null.
java.lang.NullPointerException: Mail message to be spooled cannot be null.
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:895)
at org.apache.james.transport.mailets.jsieve.delivery.SieveExecutor.execute(SieveExecutor.java:120)
at org.apache.james.transport.mailets.Sieve.service(Sieve.java:75)
at org.apache.james.mailetcontainer.impl.camel.CamelProcessor.process(CamelProcessor.java:77)
at org.apache.james.mailetcontainer.impl.camel.CamelMailetProcessor$MailetContainerRouteBuilder.handleMailet(CamelMailetProcessor.java:176)
at org.apache.james.mailetcontainer.impl.camel.CamelMailetProcessor$MailetContainerRouteBuilder.lambda$configure$0(CamelMailetProcessor.java:153)
at org.apache.camel.processor.DelegateSyncProcessor.process(DelegateSyncProcessor.java:63)
```
:-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-780485539
:green_apple: on the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #286: JAMES-3477 Avoid unneeded copies of MimeMessages
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #286:
URL: https://github.com/apache/james-project/pull/286#issuecomment-780221853
I will now merge build enhancements, and relaunch a build here, and eventually merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org