You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2024/12/10 17:47:43 UTC

[PR] chore: dependency cleanup [datafusion-ballista]

milenkovicm opened a new pull request, #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150

   # Which issue does this PR close?
   
   Closes none.
   
    # Rationale for this change
   
   There are a bit too many dependencies, some of which are duplicated and can be replaced with some other we use, some of which are not maintained. As users can create their own binaries there is no need to depend on dependencies which our binaries use. 
   
   There were cases where log and trace has been used in the same files, I have removed trace but we can revisit that decision in subsequent PRs
   
   # What changes are included in this PR?
   
   - remove few dependencies (anyhow, parse_arg)
   - make few dependencies optional. dependencies used in executor and scheduler binaries are optional now 
   - remove use of trace in few files where log was used as well
   
   # Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: dependency cleanup [datafusion-ballista]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: dependency cleanup [datafusion-ballista]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150#discussion_r1880700303


##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########


Review Comment:
   whole point of this PR is to decrease number of dependencies used in core components 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: dependency cleanup [datafusion-ballista]

Posted by "tbar4 (via GitHub)" <gi...@apache.org>.
tbar4 commented on code in PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150#discussion_r1880720715


##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########


Review Comment:
   Thanks for the explanation!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: dependency cleanup [datafusion-ballista]

Posted by "tbar4 (via GitHub)" <gi...@apache.org>.
tbar4 commented on code in PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150#discussion_r1880688450


##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########


Review Comment:
   Can you help me understand why we are removing the tracing? I know you have a good reason, just I am missing the context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: dependency cleanup [datafusion-ballista]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150#discussion_r1880699479


##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########


Review Comment:
   we use tracing we use log, we need to pick one and stick with it. log is use across project, so i remove those few statements which used tracing 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org