You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 08:51:34 UTC
[GitHub] [incubator-doris] jackwener opened a new pull request, #9885: [fix](planner): fix pushdown predicate incompletely
jackwener opened a new pull request, #9885:
URL: https://github.com/apache/incubator-doris/pull/9885
# Proposed changes
Issue Number: close #9884
## Problem Summary:
Describe the overview of changes.
Because determining whether a predicate can be pushed down is based on `PARTITION by` (it's CommonPartitionExprs in the code)
Correct way is according to the `select Items`
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kpfly commented on pull request #9885: [fix](planner): fix pushdown predicate incompletely
Posted by GitBox <gi...@apache.org>.
kpfly commented on PR #9885:
URL: https://github.com/apache/incubator-doris/pull/9885#issuecomment-1141862456
Could you add some test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #9885: [fix](planner): fix pushdown predicate incompletely
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #9885: [fix](planner): fix pushdown predicate incompletely
URL: https://github.com/apache/incubator-doris/pull/9885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9885: [fix](planner): fix pushdown predicate incompletely
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9885:
URL: https://github.com/apache/incubator-doris/pull/9885#issuecomment-1145485165
closed, we can not push down this predicate for analytic function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org