You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/03/04 10:40:32 UTC
[PR] fix(ci): add snapshot repo [camel-k]
squakez opened a new pull request, #5209:
URL: https://github.com/apache/camel-k/pull/5209
Night checks against latest runtime are failing due to missing apache snapshot repository. This PR aims to fix it.
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(ci): add snapshot repo
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): add snapshot repo [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5209:
URL: https://github.com/apache/camel-k/pull/5209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): add snapshot repo [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5209:
URL: https://github.com/apache/camel-k/pull/5209#discussion_r1512310875
##########
script/get_catalog.sh:
##########
@@ -34,7 +34,7 @@ if [ ! -z $2 ]; then
fi
# Refresh catalog sets. We can clean any leftover as well.
-rm -f ${rootdir}/resources/camel-catalog-*
+rm -f ${rootdir}/pkg/resources/resources/camel-catalog-*
Review Comment:
Yes. In a previous work we have moved to use `go:embed` and we kept using the same structure (config dir and resources dir) under the same directory to avoid making any more disruptive change. Ideally we'd need to normalize that to use a flat directory. But that would be another chunk of work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): add snapshot repo [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #5209:
URL: https://github.com/apache/camel-k/pull/5209#discussion_r1511508001
##########
script/get_catalog.sh:
##########
@@ -34,7 +34,7 @@ if [ ! -z $2 ]; then
fi
# Refresh catalog sets. We can clean any leftover as well.
-rm -f ${rootdir}/resources/camel-catalog-*
+rm -f ${rootdir}/pkg/resources/resources/camel-catalog-*
Review Comment:
is this `resources/resources` correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org