You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/13 00:09:59 UTC
[GitHub] [airflow] kaxil opened a new pull request #9267: Add temp airflow remote manifest file to .gitignore
kaxil opened a new pull request #9267:
URL: https://github.com/apache/airflow/pull/9267
This temp file is created at https://github.com/apache/airflow/blob/master/scripts/ci/libraries/_build_images.sh#L246 and has been interferring in git commits
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643603588
> # Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
hmm, so the comment is wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643605814
> hmm, so the comment is wrong?
The comment is still valid. We can't use `mktemp` (create temporary file), but we can use `mktemp -d` (create temporary directory).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643646639
Yup agree with you'll. Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643574179
Why don't we move this file to the temp directory?
````diff
- # Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
- TMP_CONTAINER_ID="remote-airflow-manifest-$$.container_id"
+ TMP_CONTAINER_DIR="$(mktemp -d)"
+ TMP_CONTAINER_ID="$(TMP_CONTAINER_DIR)/remote-airflow-manifest-$$.container_id"
FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_DIR")
TMP_MANIFEST_REMOTE_JSON=$(mktemp)
TMP_MANIFEST_REMOTE_SHA=$(mktemp)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle edited a comment on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643603588
> Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
hmm, so the comment is wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643588552
Agree - moving it TMP_DIR is much better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643574179
Why don't we move this file to the temp directory?
```diff
# Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
- TMP_CONTAINER_ID="remote-airflow-manifest-$$.container_id"
- FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_ID")
+ TMP_CONTAINER_DIR="$(mktemp -d)"
+ TMP_CONTAINER_ID="$(TMP_CONTAINER_DIR)/remote-airflow-manifest-$$.container_id"
+ FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_DIR")
TMP_MANIFEST_REMOTE_JSON=$(mktemp)
TMP_MANIFEST_REMOTE_SHA=$(mktemp)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9267: Remove generating temp remote manifest file in project dir
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9267:
URL: https://github.com/apache/airflow/pull/9267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643574179
Why don't we move this file to the temp directory?
```diff
# Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
- TMP_CONTAINER_ID="remote-airflow-manifest-$$.container_id"
+ TMP_CONTAINER_DIR="$(mktemp -d)"
+ TMP_CONTAINER_ID="$(TMP_CONTAINER_DIR)/remote-airflow-manifest-$$.container_id"
FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_DIR")
TMP_MANIFEST_REMOTE_JSON=$(mktemp)
TMP_MANIFEST_REMOTE_SHA=$(mktemp)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643574179
Why don't we move this file to the temp directory?
```diff
- # Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
- TMP_CONTAINER_ID="remote-airflow-manifest-$$.container_id"
+ TMP_CONTAINER_DIR="$(mktemp -d)"
+ TMP_CONTAINER_ID="$(TMP_CONTAINER_DIR)/remote-airflow-manifest-$$.container_id"
FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_DIR")
TMP_MANIFEST_REMOTE_JSON=$(mktemp)
TMP_MANIFEST_REMOTE_SHA=$(mktemp)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on pull request #9267: Add temp airflow remote manifest file to .gitignore
Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643611489
I see. Thanks 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org