You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 11:26:33 UTC

[GitHub] [flink] TJX2014 opened a new pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

TJX2014 opened a new pull request #18299:
URL: https://github.com/apache/flink/pull/18299


   ## What is the purpose of the change
   This pull request fix the issue about DelimitedInputFormat can not deal with compressed file correctly
   
   ## Brief change log
   An compressed tag added to show if the file is compressed and the splitLength should be set to -1 to read whole split
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   Add test that compressed file can be deal with correctly by org.apache.flink.api.common.io.DelimitedInputFormat
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336354






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336035


   hi @Airblader , I have reword the commit to fix the issue from https://github.com/apache/flink/pull/18273, 
   please help me review the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336354


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bc776911e40e4ce9a4bc4d2394da2b833738ddd8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336354


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29099",
       "triggerID" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28984",
       "triggerID" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bc776911e40e4ce9a4bc4d2394da2b833738ddd8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29099) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28984) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007337293


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit bc776911e40e4ce9a4bc4d2394da2b833738ddd8 (Fri Jan 07 11:30:32 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1011936557


   hi @fapaul, could you please help me review the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1011935088


   hi @zentol, could you please help me review the PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336354






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1010761768


   @AHeise could you check, is falling but with things not related to this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 commented on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 commented on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336035


   hi @Airblader , I have reword the commit to fix the issue from https://github.com/apache/flink/pull/18273, 
   please help me review the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 edited a comment on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1011936557






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] TJX2014 edited a comment on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
TJX2014 edited a comment on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1011936557






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18299: [FLINK-25311][core] Fix deal with delimited compressed file not correctly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18299:
URL: https://github.com/apache/flink/pull/18299#issuecomment-1007336354


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29099",
       "triggerID" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28984",
       "triggerID" : "bc776911e40e4ce9a4bc4d2394da2b833738ddd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bc776911e40e4ce9a4bc4d2394da2b833738ddd8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29099) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28984) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org