You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/28 18:44:54 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3212: fs/lfs: Update version to 2.4.0
xiaoxiang781216 opened a new pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212
## Summary
And redirect assert and log to NuttX's version
which is possible after:
```
commit c0cc0a417e727764ccce6f1284e3570898d750e6
Author: Christopher Haster <ch...@utexas.edu>
Date: Mon Jan 18 14:01:53 2021 -0600
Enabled overriding of LFS_ASSERT/TRACE/DEBUG/etc
This is useful for testing the new erroring assert behavior in CI.
Asserts do not error by default, so this macro needs to be overriden.
It is possible to test this behavior using the existing option of
overriding lfs_util.h with a custom file, by using a small sed
one-line script. But this is much simpler.
This does raise the question if more of the configuration options in
lfs_util.h should be opened up for function-like macro overrides.
``
## Impact
Move to the latest official release
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-808949843
Looks like the CI failure is here:
```
====================================================================================
Configuration/Tool: sim/tcpblaster
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 132 100 132 0 0 2588 0 --:--:-- --:--:-- --:--:-- 2588
100 133 100 133 0 0 1266 0 --:--:-- --:--:-- --:--:-- 1266
100 119k 0 119k 0 0 500k 0 --:--:-- --:--:-- --:--:-- 500k
Error: littlefs/littlefs/lfs.c:429:13: error: 'lfs_mlist_isopen' defined but not used [-Werror=unused-function]
429 | static bool lfs_mlist_isopen(struct lfs_mlist *head,
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:79: lfs.o] Error 1
make[1]: Target 'libfs.a' not remade because of errors.
make: *** [tools/LibTargets.mk:83: fs/libfs.a] Error 2
make: Target 'all' not remade because of errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-812918207
@btashton already approved this, let's merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-809103950
@btashton it turn out that littlefs code looks good, the more reasonable fix is to ensure that assert reference it's expression(without any side effect without NDEBUG/CONFIG_DEBUG_ASSERTIONS) in all case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-809111654
Yes these macros are better so we do not accidentally runtime evaluate something in UNUSED();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-809022060
The error from the official release, I will provide a patch to mainline. Before the littlefs community release the new version, we have to apply my patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-809103950
@btashton it turn out that littlefs code looks good, the more reasonable fix is to ensure that assert reference it's expression(without any side effect when NDEBUG=n/CONFIG_DEBUG_ASSERTIONS=y) in all case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-812817710
@btashton it is finally pass CI, coud you review again and merge it if no more concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #3212: fs/lfs: Update version to 2.4.0
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org