[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2243: Retry GCP requests on server error

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2243:
URL: https://github.com/apache/arrow-rs/pull/2243#discussion_r934370802


##########
object_store/Cargo.toml:
##########
@@ -48,6 +48,7 @@ quick-xml = { version = "0.23.0", features = ["serialize"], optional = true }
 rustls-pemfile = { version = "1.0", default-features = false, optional = true }
 ring = { version = "0.16", default-features = false, features = ["std"] }
 base64 = { version = "0.13", default-features = false, optional = true }
+rand = { version = "0.8", optional = true, features = ["std", "std_rng"] }

Review Comment:
   I was following the pattern established above, I'm not really sure which is better tbh. Using default-features is nice, but some crates have lots, I went for consistency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org