You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "bbejeck (via GitHub)" <gi...@apache.org> on 2024/10/25 20:15:48 UTC

[PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

bbejeck opened a new pull request, #17603:
URL: https://github.com/apache/kafka/pull/17603

   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17603:
URL: https://github.com/apache/kafka/pull/17603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #17603:
URL: https://github.com/apache/kafka/pull/17603#issuecomment-2448386331

   Thanks for merging @chia7712!
   
   [Link to passing system test](https://semaphore.ci.confluent.io/jobs/9bbf9044-bc0e-4d9b-ba5a-eaa243eb48b2/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976)
   
   ![broker_compatibility_test_results](https://github.com/user-attachments/assets/21edd1ef-5dfa-48ad-bfd0-979290182c58)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #17603:
URL: https://github.com/apache/kafka/pull/17603#discussion_r1823063591


##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -60,17 +53,15 @@ def __init__(self, test_context):
                                            self.output,
                                            "stream-broker-compatibility-verify-consumer")
 
-    def setUp(self):
-        self.zk.start()
-
 
     @cluster(num_nodes=4)
-    @matrix(broker_version=[str(LATEST_1_0),str(LATEST_1_1),str(LATEST_2_0),str(LATEST_2_1),
-                            str(LATEST_2_2),str(LATEST_2_3),str(LATEST_2_4),str(LATEST_2_5),
-                            str(LATEST_2_6),str(LATEST_2_7),str(LATEST_2_8),str(LATEST_3_0),
-                            str(LATEST_3_1),str(LATEST_3_2),str(LATEST_3_3),str(LATEST_3_4),
-                            str(LATEST_3_5),str(LATEST_3_6),str(LATEST_3_7),str(LATEST_3_8)])
-    def test_compatible_brokers_eos_disabled(self, broker_version):
+    @matrix(broker_version=[str(LATEST_2_8),

Review Comment:
   ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #17603:
URL: https://github.com/apache/kafka/pull/17603#discussion_r1817384112


##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -18,34 +18,27 @@
 from ducktape.mark.resource import cluster
 from ducktape.tests.test import Test
 from ducktape.utils.util import wait_until
-from kafkatest.services.kafka import KafkaService
+from kafkatest.services.kafka import KafkaService, quorum
 from kafkatest.services.streams import StreamsBrokerCompatibilityService
 from kafkatest.services.verifiable_consumer import VerifiableConsumer
-from kafkatest.services.zookeeper import ZookeeperService
-from kafkatest.version import LATEST_1_0, LATEST_1_1, \
-    LATEST_2_0, LATEST_2_1, LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5, LATEST_2_6, LATEST_2_7, LATEST_2_8, \
+from kafkatest.version import LATEST_2_8, \
     LATEST_3_0, LATEST_3_1, LATEST_3_2, LATEST_3_3, LATEST_3_4, LATEST_3_5, LATEST_3_6, LATEST_3_7, LATEST_3_8, KafkaVersion
 
 
 class StreamsBrokerCompatibility(Test):
     """
     These tests validates that
-    - Streams works for older brokers 0.11 (or newer)
-    - Streams w/ EOS-alpha works for older brokers 0.11 (or newer)
     - Streams w/ EOS-v2 works for older brokers 2.5 (or newer)

Review Comment:
   ```suggestion
       - Streams w/ ALOS and EOS-v2 works for older brokers 2.8 (or newer)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #17603:
URL: https://github.com/apache/kafka/pull/17603#issuecomment-2448263566

   Confirmed 2.8.2 fails in system test per [previous comment](https://github.com/apache/kafka/pull/17603#discussion_r1818118747)
   
   ![broker_fails_at_2 8](https://github.com/user-attachments/assets/8cabab58-42d4-4759-8343-6c4d9c50ffb7)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17603:
URL: https://github.com/apache/kafka/pull/17603#discussion_r1818118747


##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -60,17 +53,15 @@ def __init__(self, test_context):
                                            self.output,
                                            "stream-broker-compatibility-verify-consumer")
 
-    def setUp(self):
-        self.zk.start()
-
 
     @cluster(num_nodes=4)
-    @matrix(broker_version=[str(LATEST_1_0),str(LATEST_1_1),str(LATEST_2_0),str(LATEST_2_1),
-                            str(LATEST_2_2),str(LATEST_2_3),str(LATEST_2_4),str(LATEST_2_5),
-                            str(LATEST_2_6),str(LATEST_2_7),str(LATEST_2_8),str(LATEST_3_0),
-                            str(LATEST_3_1),str(LATEST_3_2),str(LATEST_3_3),str(LATEST_3_4),
-                            str(LATEST_3_5),str(LATEST_3_6),str(LATEST_3_7),str(LATEST_3_8)])
-    def test_compatible_brokers_eos_disabled(self, broker_version):
+    @matrix(broker_version=[str(LATEST_2_8),

Review Comment:
   2.8.2 does not support Producer IDs in kraft (see https://github.com/apache/kafka/commit/e97cff2702b6ba836c7925caa36ab18066a7c95d).



##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -87,11 +78,12 @@ def test_compatible_brokers_eos_disabled(self, broker_version):
         self.kafka.stop()
 
     @cluster(num_nodes=4)
-    @matrix(broker_version=[str(LATEST_2_5),str(LATEST_2_6),str(LATEST_2_7),str(LATEST_2_8),
+    @matrix(broker_version=[str(LATEST_2_8),

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org