You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2022/04/11 19:11:37 UTC
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18400
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
It was found that the ehcache sizeof (version 0.3.0) library used by
CatalogdMetaProvider can fail due to an InaccessibleObjectException
during reflection and cause the impalad to stuck during startup
indefinitely. This could trigger IMPALA-7168 which affects sync_ddl
queries running on unaffected impalads.
This patch upgrades the version of the ehcache sizeof library so that
the exception could be handled within the ehcache sizeof library after
the upgrade.
Testing:
- Verified that the patch passes Impala's core tests.
Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
---
M fe/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/18400/1
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 1:
Hi Quanlong and Vincent, please let me know if you have any comment on this patch. Thanks very much for the help!
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Apr 2022 19:12:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8038/
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 17:58:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2:
> Patch Set 2: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8038/
test_array_in_select_list and test_basic_joins failed in https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5556/ with the following exception.
E ImpalaBeeswaxException: ImpalaBeeswaxException:
E INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>
E MESSAGE: OutOfMemoryError: GC overhead limit exceeded
I suspect this may not be caused by my patch since we got a successful build against the same patch at https://jenkins.impala.io/job/pre-review-test/1319/.
We may try re-triggering the Jenkins job(s).
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 18:05:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (395) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:37:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
It was found that the ehcache sizeof (version 0.3.0) library used by
CatalogdMetaProvider can fail due to an InaccessibleObjectException
during reflection and cause the impalad to stuck during startup
indefinitely. This could trigger IMPALA-7168 which affects sync_ddl
queries running on unaffected impalads.
This patch upgrades the version of the ehcache sizeof library so that
the exception could be handled within the ehcache sizeof library after
the upgrade.
Testing:
- Verified that the patch passes Impala's core tests.
Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Reviewed-on: http://gerrit.cloudera.org:8080/18400
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M fe/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Anonymous Coward (395): Looks good to me, but someone else must approve
Quanlong Huang: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10427/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Apr 2022 19:31:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2: Verified+1 Code-Review+2
The failure is unrelated. Merging this. Thank Fang-Yu!
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (395)
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:07:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8038/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:35:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:34:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18400 )
Change subject: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
Gerrit-Change-Number: 18400
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:35:07 +0000
Gerrit-HasComments: No