You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/20 07:46:20 UTC

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #560: [IOTDB-247] Optimize Dynamic Config with ActiveTimeSeriesCounter

fanhualta commented on a change in pull request #560: [IOTDB-247] Optimize Dynamic Config with ActiveTimeSeriesCounter
URL: https://github.com/apache/incubator-iotdb/pull/560#discussion_r348327130
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/conf/adapter/ActiveTimeSeriesCounter.java
 ##########
 @@ -59,11 +59,12 @@ public void init(String storageGroup) {
 
   @Override
   public void offer(String storageGroup, String device, String measurement) {
+    String path = device + "." + measurement;
 
 Review comment:
   It's better to replace "." with `IoTDBConstant.PATH_SEPARATOR`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services