[GitHub] [incubator-superset] ktmud commented on pull request #10475: fix(dashboard): add animation state to fix tab switch re-renders

[GitBox <gi...@apache.org>]

ktmud commented on pull request #10475:
URL: https://github.com/apache/incubator-superset/pull/10475#issuecomment-668362131


   @graceguo-supercat Thanks for pointing me to the `gridComponents/Chart.jsx` file. Totally forgot we have this file, too.
   
   Just [optimized](https://github.com/apache/incubator-superset/pull/10475/commits/ab93026c90b9abd1e781ef9a86eef0618ed2d195) my solution a little bit more and had more testing on re-renders (with console logging on `shouldComponentUpdate`). Didn't notice any noticeable performance regression.
   
   @bryanck could you test again and lmk if there's any other issue coming up?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org