You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/06/12 02:28:48 UTC

[PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

kou opened a new pull request, #46786:
URL: https://github.com/apache/arrow/pull/46786

   ### Rationale for this change
   
   If cpplint outputs "Done ..." for each file, it's difficult that we find lint errors. 
   
   ### What changes are included in this PR?
   
   Suppress "Done ..." messages.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46786:
URL: https://github.com/apache/arrow/pull/46786#discussion_r2142307180


##########
.pre-commit-config.yaml:
##########
@@ -77,6 +77,7 @@ repos:
         alias: cpp
         name: C++ Lint
         args:
+          - "--quiet"

Review Comment:
   this still shows the relevant error, it just removes the spurious `Done` messages, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46786:
URL: https://github.com/apache/arrow/pull/46786#discussion_r2142442323


##########
.pre-commit-config.yaml:
##########
@@ -77,6 +77,7 @@ repos:
         alias: cpp
         name: C++ Lint
         args:
+          - "--quiet"

Review Comment:
   Right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46786:
URL: https://github.com/apache/arrow/pull/46786#issuecomment-2964819714

   :warning: GitHub issue #46785 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46786:
URL: https://github.com/apache/arrow/pull/46786#issuecomment-3638599083

   After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 316e02813305603eee22627045085c5d4ad72b48.
   
   None of the specified runs were found on the Conbench server.
   
   The [full Conbench report](https://github.com/apache/arrow/runs/57706172749) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46785: [CI][Dev][C++] Suppress needless outputs of cpplint with pre-commit [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #46786:
URL: https://github.com/apache/arrow/pull/46786


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org