You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/09/25 18:04:32 UTC
[PR] fix: avoid reflective help text formatting [maven-help-plugin]
efegokdemir opened a new pull request, #443:
URL: https://github.com/apache/maven-help-plugin/pull/443
## Summary
`describe` no longer depends on the generated `HelpMojo.toLines` method through reflection. The formatting implementation is kept local and rejects indentation sizes that would overflow the backing buffer.
## Changes
- move line wrapping into `DescribeMojo`
- guard repeated indentation against integer overflow
- add regression coverage for oversized indentation
## Testing
- `mvn -q -Dspotless.skip=true -DskipTests validate`
- `mvn -q -Dspotless.skip=true -Dcheckstyle.skip=true -Dtest=DescribeMojoTest test`
- `git diff --check`
Fixes #390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: avoid reflective help text formatting [maven-help-plugin]
Posted by "efegokdemir (via GitHub)" <gi...@apache.org>.
efegokdemir commented on PR #443:
URL: https://github.com/apache/maven-help-plugin/pull/443#issuecomment-6136370837
Moved assertNull before assertThrows in DescribeMojoTest. `mvn -Prun-its verify` (31 unit tests and 36 integration tests) and `mvn spotless:check` pass on JDK 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: avoid reflective help text formatting [maven-help-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #443:
URL: https://github.com/apache/maven-help-plugin/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org