You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/26 03:58:11 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #36681: [SPARK-39299][PS] Series.autocorr use SQL.corr to avoid conversion to vector

zhengruifeng opened a new pull request, #36681:
URL: https://github.com/apache/spark/pull/36681

   ### What changes were proposed in this pull request?
   directly use `corr` in sql functions
   
   
   ### Why are the changes needed?
   `Correlation.corr` in the ml side will convert input columns into vectors, which can be skipped
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   existing UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #36681: [SPARK-39299][PS] Series.autocorr use SQL.corr to avoid conversion to vector

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36681: [SPARK-39299][PS] Series.autocorr use SQL.corr to avoid conversion to vector
URL: https://github.com/apache/spark/pull/36681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #36681: [SPARK-39299][PS] Series.autocorr use SQL.corr to avoid conversion to vector

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36681:
URL: https://github.com/apache/spark/pull/36681#issuecomment-1138411452

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #36681: [SPARK-39299][PS] Series.autocorr use SQL.corr to avoid conversion to vector

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #36681:
URL: https://github.com/apache/spark/pull/36681#issuecomment-1138443279

   thank you @HyukjinKwon !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org