You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wingkitlee0 (via GitHub)" <gi...@apache.org> on 2025/08/17 14:57:44 UTC
[PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
wingkitlee0 opened a new pull request, #47351:
URL: https://github.com/apache/arrow/pull/47351
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
Please remove this line and the above text before creating your pull request.
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "wingkitlee0 (via GitHub)" <gi...@apache.org>.
wingkitlee0 commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3198631307
@raulcd Thanks for looking at it! It turns out `get_file_info` has a little bit different extra error handling.
For other APIs, I was able to use `minio` locally get the expected message:
```
In [6]: fs = S3FileSystem(endpoint_override="localhost:9000", scheme="http", region="us-east-1", access_key="minioadmin", secret_key="minioadmin")
In [7]: fs.copy_file("test-bucket/a", "test-bucket/b")
---------------------------------------------------------------------------
OSError Traceback (most recent call last)
Cell In[7], line 1
----> 1 fs.copy_file("test-bucket/a", "test-bucket/b")
File ~/.pyenv/versions/3.12.10/envs/py312-arrow-dev/lib/python3.12/site-packages/pyarrow/_fs.pyx:754, in pyarrow._fs.FileSystem.copy_file()
File ~/.pyenv/versions/3.12.10/envs/py312-arrow-dev/lib/python3.12/site-packages/pyarrow/error.pxi:92, in pyarrow.lib.check_status()
OSError: When copying key 'a' in bucket 'test-bucket' to key 'b' in bucket 'test-bucket': AWS Error NO_SUCH_BUCKET during CopyObject operation: The specified bucket does not exist request ID: 185CFDB6B0C338B1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3232729361
The majority of CI failures have been fixed on main, could you please rebase to have a better CI state?
The current expected ones are the two MinGW ones, they are tracked here:
- https://github.com/apache/arrow/issues/47440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3245677937
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 590d43fb2b94cd5ea25b37fc7ea77db9994d39f5.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/49414995909) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3237149659
@AlenkaF @rok @pitrou do you want to take a look, otherwise I'll merge on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #47351:
URL: https://github.com/apache/arrow/pull/47351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "wingkitlee0 (via GitHub)" <gi...@apache.org>.
wingkitlee0 commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3202675558
Added some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3194440097
:warning: GitHub issue #47349 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47349: [C++] Include request ID in AWS S3 Error [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47351:
URL: https://github.com/apache/arrow/pull/47351#issuecomment-3244209200
> Looks good to me. Out of curiosity and out of scope: would it be a good idea to provide output of [AWSError::GetJsonPayload](https://docs.aws.amazon.com/sdk-for-cpp/latest/api/aws-cpp-sdk-core/html/class_aws_1_1_client_1_1_a_w_s_error.html#aa5b0cd5d1722f11267b07f2040fff039) or [AWSError::GetMessage](https://docs.aws.amazon.com/sdk-for-cpp/latest/api/aws-cpp-sdk-core/html/class_aws_1_1_client_1_1_a_w_s_error.html#a5d2a7157e45a3f0e61957c1788ab9dc6) too?
The message is already used. About the Payload I am unsure we want to get that by default. It can be followed up on a different issue if someone thinks it could be interesting.
I am merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org