You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Nikita Vetoshkin <ni...@gmail.com> on 2014/08/21 18:38:45 UTC
Review Request 24939: Report bind parameters on failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1728
https://issues.apache.org/jira/browse/MESOS-1728
Repository: mesos-git
Description
-------
Report bind parameters on failure
Diffs
-----
3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
Diff: https://reviews.apache.org/r/24939/diff/
Testing
-------
Built master and slave and check new error message by issuing the same commands in two separate consoles.
Thanks,
Nikita Vetoshkin
Re: Review Request 24939: Report bind parameters on failure
Posted by Tom Arnfeld <ta...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/#review51342
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Arnfeld
On Aug. 21, 2014, 6:22 p.m., Nikita Vetoshkin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24939/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 6:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1728
> https://issues.apache.org/jira/browse/MESOS-1728
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Report bind parameters on failure
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
>
> Diff: https://reviews.apache.org/r/24939/diff/
>
>
> Testing
> -------
>
> Built master and slave and check new error message by issuing the same commands in two separate consoles.
>
>
> Thanks,
>
> Nikita Vetoshkin
>
>
Re: Review Request 24939: Report bind parameters on failure
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/#review51238
-----------------------------------------------------------
Bad patch!
Reviews applied: [24939]
Failed command: git apply --index 24939.patch
Error:
error: patch failed: 3rdparty/libprocess/src/process.cpp:1629
error: 3rdparty/libprocess/src/process.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 21, 2014, 6:22 p.m., Nikita Vetoshkin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24939/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 6:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1728
> https://issues.apache.org/jira/browse/MESOS-1728
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Report bind parameters on failure
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
>
> Diff: https://reviews.apache.org/r/24939/diff/
>
>
> Testing
> -------
>
> Built master and slave and check new error message by issuing the same commands in two separate consoles.
>
>
> Thanks,
>
> Nikita Vetoshkin
>
>
Re: Review Request 24939: Report bind parameters on failure
Posted by Nikita Vetoshkin <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/
-----------------------------------------------------------
(Updated Aug. 21, 2014, 6:22 p.m.)
Review request for mesos.
Bugs: MESOS-1728
https://issues.apache.org/jira/browse/MESOS-1728
Repository: mesos-git
Description
-------
Report bind parameters on failure
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
Diff: https://reviews.apache.org/r/24939/diff/
Testing
-------
Built master and slave and check new error message by issuing the same commands in two separate consoles.
Thanks,
Nikita Vetoshkin
Re: Review Request 24939: Report bind parameters on failure
Posted by Nikita Vetoshkin <ni...@gmail.com>.
> On Aug. 21, 2014, 5:34 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1633
> > <https://reviews.apache.org/r/24939/diff/1/?file=666217#file666217line1633>
> >
> > Remove the space after inet_ntoa.
> >
> > inet_ntoa(addr.sin_addr)
>
> Vinod Kone wrote:
> great. mind also adding this to "failed to initialize socket and inet_pton" statements above?
Removed extra whitespace (probably style check should have alerted).
Vinod, I didn't quite understand where should "this" be added so it would make sense :).
- Nikita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/#review51190
-----------------------------------------------------------
On Aug. 21, 2014, 6:22 p.m., Nikita Vetoshkin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24939/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 6:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1728
> https://issues.apache.org/jira/browse/MESOS-1728
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Report bind parameters on failure
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
>
> Diff: https://reviews.apache.org/r/24939/diff/
>
>
> Testing
> -------
>
> Built master and slave and check new error message by issuing the same commands in two separate consoles.
>
>
> Thanks,
>
> Nikita Vetoshkin
>
>
Re: Review Request 24939: Report bind parameters on failure
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 21, 2014, 5:34 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1633
> > <https://reviews.apache.org/r/24939/diff/1/?file=666217#file666217line1633>
> >
> > Remove the space after inet_ntoa.
> >
> > inet_ntoa(addr.sin_addr)
great. mind also adding this to "failed to initialize socket and inet_pton" statements above?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/#review51190
-----------------------------------------------------------
On Aug. 21, 2014, 4:38 p.m., Nikita Vetoshkin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24939/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 4:38 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1728
> https://issues.apache.org/jira/browse/MESOS-1728
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Report bind parameters on failure
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
>
> Diff: https://reviews.apache.org/r/24939/diff/
>
>
> Testing
> -------
>
> Built master and slave and check new error message by issuing the same commands in two separate consoles.
>
>
> Thanks,
>
> Nikita Vetoshkin
>
>
Re: Review Request 24939: Report bind parameters on failure
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24939/#review51190
-----------------------------------------------------------
Ship it!
Thanks!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/24939/#comment89220>
Remove the space after inet_ntoa.
inet_ntoa(addr.sin_addr)
- Jie Yu
On Aug. 21, 2014, 4:38 p.m., Nikita Vetoshkin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24939/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 4:38 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1728
> https://issues.apache.org/jira/browse/MESOS-1728
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Report bind parameters on failure
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp ddcedb703cea67587c1c87993681686261107f47
>
> Diff: https://reviews.apache.org/r/24939/diff/
>
>
> Testing
> -------
>
> Built master and slave and check new error message by issuing the same commands in two separate consoles.
>
>
> Thanks,
>
> Nikita Vetoshkin
>
>