You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/06/27 10:20:24 UTC
[GitHub] [camel] orpiske opened a new pull request, #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
orpiske opened a new pull request, #10512:
URL: https://github.com/apache/camel/pull/10512
This ensures that the done callback will be called (or, at least, tried to be called) in the case of unhandled exceptions (a few rare cases involving Throwables)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10512:
URL: https://github.com/apache/camel/pull/10512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609217414
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609285788
> There is also a try catch block a bit further up, it could benefit from also call done in finally
Oh, nice. I'll add it there too. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609242235
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609242262
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609309427
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609303735
@davsclaus adding to the ones above cause side effects. This one is OK because the `callback.done(true);` is supposed to run regardless of a exception being thrown or not. On the one above, it's only called when catching an exception, so adding to the finally would also cause it to run when it shouldn't. I'm leaving as is for now - I can investigate later if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10512: CAMEL-19497: prevent unhandled exceptions from blocking indefinitely
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10512:
URL: https://github.com/apache/camel/pull/10512#issuecomment-1609278705
There is also a try catch block a bit further up, it could benefit from also call done in finally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org