You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Vidhanvyrs (via GitHub)" <gi...@apache.org> on 2023/09/08 21:56:23 UTC
[GitHub] [airflow] Vidhanvyrs opened a new pull request, #34224: Added_run_id_issue#34211
Vidhanvyrs opened a new pull request, #34224:
URL: https://github.com/apache/airflow/pull/34224
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add run_id to event logs API [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34224: Add run_id to event logs API
URL: https://github.com/apache/airflow/pull/34224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Vidhanvyrs commented on a diff in pull request #34224: Add run_id to event logs API
Posted by "Vidhanvyrs (via GitHub)" <gi...@apache.org>.
Vidhanvyrs commented on code in PR #34224:
URL: https://github.com/apache/airflow/pull/34224#discussion_r1320386963
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
hey @Taragolis I have just updated it but i was unable to commit it this is what i got I tried to rebase and remove any coflicts if the branch had still this error persuade
Need Help here
! [rejected] NewBranch34211 -> NewBranch34211 (non-fast-forward)
error: failed to push some refs to 'https://github.com/Vidhanvyrs/airflow.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34224: Add run_id to event logs API
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34224:
URL: https://github.com/apache/airflow/pull/34224#discussion_r1320515753
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
I thought about avoiding adding a new column to Log and doing a join with DagRun to retrieve the run_id, but since we are discussing removing the run_date unique constraint, I think adding a new column is the best choice here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add run_id to event logs API [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34224:
URL: https://github.com/apache/airflow/pull/34224#issuecomment-1907128386
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add run_id to event logs API [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #34224:
URL: https://github.com/apache/airflow/pull/34224#issuecomment-1759296563
@Vidhanvyrs can you look into the failing tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Vidhanvyrs commented on a diff in pull request #34224: Add run_id to event logs API
Posted by "Vidhanvyrs (via GitHub)" <gi...@apache.org>.
Vidhanvyrs commented on code in PR #34224:
URL: https://github.com/apache/airflow/pull/34224#discussion_r1320386963
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
hey @Taragolis I have just updated it but i was unable to commit it this is what i got I tried to rebase and remove any coflicts if the branch had still this error persuade
Need Help here
! [rejected] NewBranch34211 -> NewBranch34211 (non-fast-forward)
error: failed to push some refs to 'https://github.com/Vidhanvyrs/airflow.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34224: Added_run_id_issue#34211
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34224:
URL: https://github.com/apache/airflow/pull/34224#issuecomment-1712267937
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Vidhanvyrs commented on a diff in pull request #34224: Add run_id to event logs API
Posted by "Vidhanvyrs (via GitHub)" <gi...@apache.org>.
Vidhanvyrs commented on code in PR #34224:
URL: https://github.com/apache/airflow/pull/34224#discussion_r1320385880
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
Oops i forgot to update that !!
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
On it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #34224: Add run_id to event logs API
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34224:
URL: https://github.com/apache/airflow/pull/34224#discussion_r1320381193
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
Review Comment:
You forget to import aliased
##########
airflow/api_connexion/endpoints/event_log_endpoint.py:
##########
@@ -69,9 +69,11 @@ def get_event_logs(
"execution_date",
"owner",
"extra",
+ "run_id",
]
total_entries = session.scalars(func.count(Log.id)).one()
- query = select(Log)
+ run_id_alias = aliased(Log)
+ query = select(Log, run_id_alias.run_id.label("run_id"))
Review Comment:
I'm confused, how it expected to be work? `Log` doesn't have `run_id`
https://github.com/apache/airflow/blob/ae3a61775a79a3000df0a8bdf50807033f4e3cdc/airflow/models/log.py#L27-L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #34224: Add run_id to event logs API
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #34224:
URL: https://github.com/apache/airflow/pull/34224#issuecomment-1720848366
Is this new field assigned to anywhere? I don’t see any chances regarding that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org