You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2014/12/22 13:37:50 UTC
svn commit: r1647301 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java
Author: msahyoun
Date: Mon Dec 22 12:37:50 2014
New Revision: 1647301
URL: http://svn.apache.org/r1647301
Log:
PDFBOX-2576 resolve TODO in code
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java?rev=1647301&r1=1647300&r2=1647301&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElement.java Mon Dec 22 12:37:50 2014
@@ -31,9 +31,8 @@ import org.apache.pdfbox.pdmodel.documen
/**
* A structure element.
*
- * @author <a href="mailto:ben@benlitchfield.com">Ben Litchfield</a>,
- * <a href="mailto:Johannes%20Koch%20%3Ckoch@apache.org%3E">Johannes Koch</a>
- * @version $Revision: 1.3 $
+ * @author Ben Litchfield
+ * @author Johannes Koch
*/
public class PDStructureElement extends PDStructureNode
{
@@ -222,7 +221,7 @@ public class PDStructureElement extends
int revisionNumber = attributes.getRevisionNumber(i);
if (revisionNumber < 0)
{
- // TODO throw Exception because revision number must be > -1?
+ throw new IllegalArgumentException("The revision number shall be > -1");
}
array.add(attributeObject);
array.add(COSInteger.get(revisionNumber));
@@ -388,7 +387,7 @@ public class PDStructureElement extends
int revisionNumber = classNames.getRevisionNumber(i);
if (revisionNumber < 0)
{
- // TODO throw Exception because revision number must be > -1?
+ throw new IllegalArgumentException("The revision number shall be > -1");
}
array.add(COSName.getPDFName(className));
array.add(COSInteger.get(revisionNumber));
@@ -484,7 +483,7 @@ public class PDStructureElement extends
{
if (revisionNumber < 0)
{
- // TODO throw Exception because revision number must be > -1?
+ throw new IllegalArgumentException("The revision number shall be > -1");
}
this.getCOSDictionary().setInt(COSName.R, revisionNumber);
}