[GitHub] [incubator-kyuubi] hddong commented on a diff in pull request #3374: Support password authentication for trino engine

[GitBox <gi...@apache.org>]

hddong commented on code in PR #3374:
URL: https://github.com/apache/incubator-kyuubi/pull/3374#discussion_r965458239


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -897,6 +897,55 @@ object KyuubiConf {
       .stringConf
       .createOptional
 
+  val ENGINE_TRINO_CONNECTION_PASSWORD: OptionalConfigEntry[String] =
+    buildConf("kyuubi.session.engine.trino.connection.password")
+      .doc("The password used for connecting to trino cluster")

Review Comment:
   > fill password in URL but not `beeline -p` is not intuitive i think
   
   Yes, but Kyuubi server authentication uses `-P`. And the passwords of server and engine are different at most time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org