[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #649: migrating kryo's dependency from twitter chill to plain kryo library

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #649: migrating kryo's dependency from twitter chill to plain kryo library
URL: https://github.com/apache/incubator-hudi/pull/649#discussion_r277906834
 
 

 ##########
 File path: packaging/hoodie-hadoop-mr-bundle/pom.xml
 ##########
 @@ -211,6 +211,7 @@
                   <include>com.twitter.common:objectsize</include>
                   <include>commons-logging:commons-logging</include>
                   <include>commons-io:commons-io</include>
+                  <include>com.esotericsoftware:kryo-shaded</include>
                 </includes>
 
 Review comment:
   You would need to include the dependencies of kryo-shaded. 
   com.esotericsoftware » minlog
   & org.objenesis » objenesis 
   
   Please run the demo steps locally http://hudi.incubator.apache.org/docker_demo.html to verify if all the steps succeeds.
   
   Also, you would need similar changes in hoodie-utilities
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services