You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 12:49:47 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #14351: ARROW-17904: [C++] [WIP] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

pitrou commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1004444530


##########
cpp/src/arrow/util/crc32.cc:
##########
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   If non-trivial changes were made to the code then it should stay in `arrow/util`, IMHO. Code in `arrow/vendored` should be mostly identical to upstream and easily updateable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org