You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/02/13 00:13:38 UTC
Review Request 42627: AMBARI-15037 When saving a SCRIPT edit,
it loses the script path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42627/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Richard Zang, Srimanth Gunturi, and Yusaku Sako.
Summary (updated)
-----------------
AMBARI-15037 When saving a SCRIPT edit, it loses the script path
Bugs: AMBARI-15037
https://issues.apache.org/jira/browse/AMBARI-15037
Repository: ambari
Description (updated)
-------
For script alerts, after editing in the UI and saving the change, it loses the "path".
Resolution is to add the whole source data instead of only the parameters
Diffs (updated)
-----
ambari-web/app/controllers/main/alerts/definition_configs_controller.js ec5680c
ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js c957efd
Diff: https://reviews.apache.org/r/42627/diff/
Testing (updated)
-------
Modified unit test. Local ambari-web test passed.
24292 tests complete (21 seconds)
156 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 42627: AMBARI-15037 When saving a SCRIPT edit,
it loses the script path
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42627/#review119117
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 12, 2016, 6:13 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42627/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 6:13 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Richard Zang, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-15037
> https://issues.apache.org/jira/browse/AMBARI-15037
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For script alerts, after editing in the UI and saving the change, it loses the "path".
> Resolution is to add the whole source data instead of only the parameters
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/alerts/definition_configs_controller.js ec5680c
> ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js c957efd
>
> Diff: https://reviews.apache.org/r/42627/diff/
>
>
> Testing
> -------
>
> Modified unit test. Local ambari-web test passed.
> 24292 tests complete (21 seconds)
> 156 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>