You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/03 06:31:22 UTC
[GitHub] [incubator-streampark] lvshaokang opened a new pull request, #1953: [Feature] Add probes for liveness check.
lvshaokang opened a new pull request, #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
Add probes for liveness checking and better adaptation to k8s deployment[1].
1.https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo commented on PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953#issuecomment-1301709893
@lvshaokang I'm not sure if this version will be merged, because this is a feature, and it is planned not to add any new features in November.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] lvshaokang commented on pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
lvshaokang commented on PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953#issuecomment-1301730531
@MonsterChenzhuo I understand your concern, or this is an enhancement, not a new feature, it better adapt the streampark service for deployment on k8s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953#issuecomment-1304496388
Thanks for your contribution, I will review it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] lvshaokang commented on pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
lvshaokang commented on PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953#issuecomment-1301697818
cc @MonsterChenzhuo @wolfboys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1953: [Feature] Add probes for liveness check.
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1953:
URL: https://github.com/apache/incubator-streampark/pull/1953#issuecomment-1304498191
It looks good, can you provide relevant documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org