You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gaborgsomogyi (via GitHub)" <gi...@apache.org> on 2025/10/14 07:58:37 UTC

[PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

gaborgsomogyi opened a new pull request, #27112:
URL: https://github.com/apache/flink/pull/27112

   ## What is the purpose of the change
   
   Pandas 2.3+ drops cp39 wheels → sdist build fails on manylinux2014. In this PR I've upper bounded pandas to <2.3 to avoid the python 3.9 issue. The limit can be removed when we drop 3.9 support.
   
   ## Brief change log
   
   Upper bounded pandas to <2.3.
   
   ## Verifying this change
   
   Nightly pipeline run manually.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on code in PR #27112:
URL: https://github.com/apache/flink/pull/27112#discussion_r2428356540


##########
flink-python/setup.py:
##########
@@ -322,7 +322,7 @@ def extracted_output_files(base_dir, file_path, output_directory):
                         'pytz>=2018.3', 'fastavro>=1.1.0,!=1.8.0', 'requests>=2.26.0',
                         'protobuf>=3.19.0',
                         'numpy>=1.22.4',
-                        'pandas>=1.3.0',
+                        'pandas>=1.3.0,<2.3',

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi merged PR #27112:
URL: https://github.com/apache/flink/pull/27112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #27112:
URL: https://github.com/apache/flink/pull/27112#issuecomment-3400717993

   Intended to merge and backport to all active branches after green azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on code in PR #27112:
URL: https://github.com/apache/flink/pull/27112#discussion_r2428345504


##########
flink-python/setup.py:
##########
@@ -322,7 +322,7 @@ def extracted_output_files(base_dir, file_path, output_directory):
                         'pytz>=2018.3', 'fastavro>=1.1.0,!=1.8.0', 'requests>=2.26.0',
                         'protobuf>=3.19.0',
                         'numpy>=1.22.4',
-                        'pandas>=1.3.0',
+                        'pandas>=1.3.0,<2.3',

Review Comment:
   Maybe comment about the reason & link to this PR/Jira?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #27112:
URL: https://github.com/apache/flink/pull/27112#issuecomment-3401377613

   Oh gosh, fixed tox issues:
   ```
   Oct 14 10:57:15 ./setup.py:325:46: E261 at least two spaces before inline comment
   Oct 14 10:57:15 ./setup.py:325:101: E501 line too long (120 > 100 characters)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27112:
URL: https://github.com/apache/flink/pull/27112#issuecomment-3400570927

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "761644ad720738d9c68b393da840a3d95bbd0af1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "761644ad720738d9c68b393da840a3d95bbd0af1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 761644ad720738d9c68b393da840a3d95bbd0af1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38513][python]Fix pandas 2.3+ cp39 issue [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #27112:
URL: https://github.com/apache/flink/pull/27112#issuecomment-3400551318

   cc @dianfu @Zakelly I've started a nightly run with this branch here: https://github.com/gaborgsomogyi/flink/actions/runs/18489490700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org