You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xil-db (via GitHub)" <gi...@apache.org> on 2023/11/13 17:23:26 UTC
Re: [PR] [SPARK-45892][SQL] Refactor optimizer plan validation to decouple `validateSchemaOutput` and `validateExprIdUniqueness` [spark]
xil-db commented on code in PR #43761:
URL: https://github.com/apache/spark/pull/43761#discussion_r1391441829
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala:
##########
@@ -381,6 +381,15 @@ object LogicalPlanIntegrity {
}.flatten
}
+ def validateSchemaOutput(previousPlan: LogicalPlan, currentPlan: LogicalPlan): Option[String] = {
+ if (!DataTypeUtils.equalsIgnoreNullability(previousPlan.schema, currentPlan.schema)) {
+ Some(s"The plan output schema has changed from ${previousPlan.schema.sql} to " +
Review Comment:
Yes, we can do that. The current style is consistent with other validation functions so if we want to switch to string block syntax, I think we should change other validation functions, too. I don't have a strong opinion on this, please let me know if that's preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org